Support calling remove callback multiple times#300
Open
nwalters512 wants to merge 1 commit intoraszi:masterfrom
Open
Support calling remove callback multiple times#300nwalters512 wants to merge 1 commit intoraszi:masterfrom
nwalters512 wants to merge 1 commit intoraszi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While refactoring some code, I ended up accidentally calling the remove callback multiple times. It took me way too long to figure out why it seemed like my process was hanging: because the callback passed to the remove callback isn't invoked when the remove callback is called multiple times.
I acknowledge that one shouldn't end up calling the remove callback multiple times in normal usage, but it's a big violation of expectations for my own callback to never be called in that situation. I'm hoping you'll accept this patch. Thank you!